search

atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
263 stars 15 forks source link

feat: send signature rejection notification in the _handleSshRequestNotification method #1170

Open realvarx opened 1 week ago

realvarx commented 1 week ago

In the _handleNptRequestNotification method, if the signature verification fails, a rejection notification is sent:

https://github.com/atsign-foundation/noports/blob/675685046a472003ded95b46d3725ed9a0c50abb/packages/dart/noports_core/lib/src/sshnpd/sshnpd_impl.dart#L444-L461

But that doesn't happen on the _handleSshRequestNotification method:

https://github.com/atsign-foundation/noports/blob/675685046a472003ded95b46d3725ed9a0c50abb/packages/dart/noports_core/lib/src/sshnpd/sshnpd_impl.dart#L632-L640