Closed sitaram-kalluri closed 1 day ago
Please add an e2e test for npt which uses no-encrypt-traffic. You can copy npt_to_port_22 to a new file in the tests/e2e_all/scripts/tests directory and modify it appropriately
@gkc : Added E2E test : npt_to_port_22_no_encrypt_traffic. Please review the changes.
So, in C multi, I need to check for connect:no:encrypt
and if so, disable encryption?
LGTM
@XavierChanth can you take a quick look over this also please?
@sitaram-kalluri We will need to do the same for the C sshnpd and srv implementations. Can you create a ticket for that please?
@gkc : Sure, will create tickets for both.
So, in C multi, I need to check for
connect:no:encrypt
and if so, disable encryption?
I think so. @sitaram-kalluri plz confirm
So, in C multi, I need to check for
connect:no:encrypt
and if so, disable encryption?I think so. @sitaram-kalluri plz confirm
"Yes, that's correct. We need to check for 'connect:no:encrypt' and disable encryption accordingly. Just to clarify, I introduced 'connect:no:encrypt' in the srv, so it may not be present in the at_c repo."
- What I did
- How I did it
In bin/npt.dart, introduced the encrypt-rvd-traffic flag, allowing users to toggle whether data transmission should be encrypted or sent in plain text.
In srv_impl.dart, modified the run() method in the SrvImplDart class to support data transmission in plain text. Previously, the run() method only supported encrypted transmission.
Changes in _runClientSideMulti() and _runDaemonSideMulti() methods:
- How to verify it
Tested the below scenarios manually:
Attaching the demon and client logs:
Daemon logs
Client logs:
Ran npt command without " --no-encrypt-rvd-traffic" able to run command successfully and connect to remote machine with SSH command. This is to verify the existing behaviour.
Daemon logs:
Client logs:
Added an End-to-End test : npt_to_port_22_no_encrypt_traffic to verify the changes - Description for the changelog
fix: Implement no-encrypt-traffic in npt