sshnpd policy handling for ssh_request - Githubissues

atsign-foundation / noports

Connect to any device with no external listening ports open

https://noports.com

BSD 3-Clause "New" or "Revised" License

272 stars 15 forks source link

sshnpd policy handling for ssh_request #1558

Open gkc opened 3 days ago

gkc commented 3 days ago

Describe the bug

sshnpd allows ssh_request if there is any policy match for the client atSign with the daemon's atSign and device name

Steps to reproduce

configure a policy with permitOpen "localhost:12345"
attempt an npt request to port 22 - it will fail
attempt an ssh_request - it will succeed

Expected behavior

policy decision should be made in the same way for both npt_request and ssh_request

Screenshots

No response

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

reported by @cconstab

gkc commented 3 days ago

@cconstab looking at the code it looks like this has already been fixed by this PR - can you retest with sshnpd from a recent alpha release?