atsign-foundation / noports

Connect to any device with no external listening ports open
https://noports.com
BSD 3-Clause "New" or "Revised" License
271 stars 15 forks source link

sshnp (pure dart): "user" ssh session doesn't close properly if the "tunnel" session closes #977

Open XavierChanth opened 6 months ago

XavierChanth commented 6 months ago

Describe the bug

Steps to reproduce

  1. Start desktop app session
  2. Turn off internet

Related branch: fix/locked-up-session

Expected behavior

Some callback / future that allows detection of the tunnel session closing from the SshnpRemoteProcess object.

Screenshots

No response

Smartphones

N/A

Were you using an atApplication when the bug was found?

No response

Additional context

No response

XavierChanth commented 6 months ago

In addition, in noports core, initialization doesn't do any Future.catchError() calls to handle async errors properly

XavierChanth commented 6 months ago

We have wrapped the pure-dart session call in a runZonedGuarded clause for the desktop application. This bug is low priority, since we were able to handle it gracefully. The CLI application already handles this since we already do the runZonedGuarded call for it.

XavierChanth commented 6 months ago

At this point, I would consider this a low priority bug, since there is a valid, reliable workaround.