search

atsushieno / ADLplug-AE

modernized ADLplug build with JUCE7 and CMake setup in JUCE6 manner
GNU General Public License v3.0
5 stars 2 forks source link

Update README.md #3

Closed cwmoriarty closed 3 months ago

cwmoriarty commented 3 months ago

Clarifying use and fixing typo

atsushieno commented 3 months ago

The README already says "Everything is still subject to changes. Do not expect it as a stable synth plugin yet."

cwmoriarty commented 3 months ago

Thanks for consideration. My PR clarifies how to install this, it's unclear I'd need to clone it outside an existing ADLplug.

And patch is mispelled.

atsushieno commented 3 months ago

Oh, ADLplug is registered as git submodule. If you run git submodule update --init --recursive you will see it checked out. Sorry, but it is a generic git repository structure that I don't think I have to add it to README. Maybe in the future, but not right now.

cwmoriarty commented 3 months ago

Yup, I just missed that at first!

Great project, BTW. I want to get ADLplug built for my M1 Mac and this is a big step toward that goal.

atsushieno commented 3 months ago

It is 99.9% on top of jpcima's great work but thank you anyway! And yes building on M1 was my need too.

cwmoriarty commented 3 months ago

@atsushieno do you happen to have any M1/ARM builds you could upload as a Release here?

I don't have a pre-macos 15.x machine handy and I'm running up against JUCE/issues/1414. Thanks.

atsushieno commented 3 months ago

I cannot sign my binaries, my Apple ID is inaccessible due to WTF reason Apple made on their secret questions (kinda well known problem). You can resort to GitHub Actions macos-14 server (fork this repo, and add your actions setup). I can try to set up it but I'll be quite busy this week so do not expect that to happen for a while...