atsushieno / aap-juce-vital

port of Vi(t)al to Audio Plugins For Android (AAP)
GNU General Public License v3.0
4 stars 1 forks source link

The shader implementation or juce::OpenGL crashes some Android devices #4

Open atsushieno opened 1 year ago

atsushieno commented 1 year ago

This happens on Lenovo TB125FU:

21:49:00.104 22844-22923 libc org....juce.vitaloid A /Users/atsushi/sources/AAP/aap-juce-vital/apps/vital/plugin/builds/Android/app/../../../../src/interface/look_and_feel/shaders.cpp:1110: GLuint Shaders::createVertexShader(juce::OpenGLExtensionFunctions &, Shaders::VertexShader) const: assertion "checkShaderCorrect(extensions, shader_id)" failed 21:49:00.105 22844-22923 libc org....juce.vitaloid A Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 22923 (Thread-2), pid 22844 (s.juce.vitaloid)

Meanwhile it just works on Pixel4a 5G, so it could be an issue on the Lenovo tablet.

Larcaster commented 4 months ago

Try to add "precision mediump float;\n" in every vertex shader before "void main() {\n" section

atsushieno commented 4 months ago

Thanks for diving into the issue.

I think I already handled that: https://github.com/atsushieno/aap-juce-vital/blob/03183540c367d7a0b9a04412045692bc1462396b/apps/vitaloid-aap.patch#L368 I'm not sure if there is any way to verify it is inserted at runtime though...!