search

atsushieno / mugene-ng

Music Macro Language to MIDI 1.0 / 2.0 compiler
MIT License
8 stars 0 forks source link

build node.js executable #4

Closed atsushieno closed 3 years ago

atsushieno commented 3 years ago

I set up webpack.config.d for this purpose, but if add binaries.executable() at kotlin { js { ... } } section in build.gradle.kts build fails like:

Module 'fs' not found
Module 'kotlinx-coroutines-core' not found

This needs to be sorted out.

atsushieno commented 3 years ago

Another blocking issue in Kotlin itself: https://youtrack.jetbrains.com/issue/KT-28664 - this makes it impossible to build mugene module for both browser and node.

atsushieno commented 3 years ago

There is no way to work around missing fs on browser(), so we skip browser() so far.

kotlinx-coroutines-core issue is gone once we removed js-specific implementation section.

We don't do with js(BOTH) or js(IR) so far (i.e. no IR) and enabled binaries.executable() as well as headless tests using karma.

Closing this as it's so far non-issue anymore. This may occur in the future whenever we play around those JS generator modes or supported environment though.