It made me notice couple of flaws on current vscode-language-review implementation.
Range information of symbols are incorrect if the file ends with non-column element (i.e. headline)
I don't get why I didn't notice when implemented this :confused:
Column boundaries are inaccurate
Upstream review.js returns "the next element's starting position" as an ending position of columns. Actually I noticed it before but thought it's a harmless overlapping. But situation changed with the new highlight feature.
Now vscode-language-review shows as if each column have extra 1 line.
= test doc
== foo
aaaaa
== bar
aaaaaggg
gaarfawe
aher
=== bar-sub
sub
====[column] bar-sub-column
column
text
text
====[/column]
aaaaa
bbbb
vscode 1.27 adds functionality to highlight regions during breadcrumbs navigation: https://code.visualstudio.com/updates/v1_27#_breadcrumbs-improvements
It made me notice couple of flaws on current vscode-language-review implementation.
Range information of symbols are incorrect if the file ends with non-column element (i.e. headline)
I don't get why I didn't notice when implemented this :confused:
Column boundaries are inaccurate
Upstream review.js returns "the next element's starting position" as an ending position of columns. Actually I noticed it before but thought it's a harmless overlapping. But situation changed with the new highlight feature.
Now vscode-language-review shows as if each column have extra 1 line.