search

att-comdev / armada

This project has moved to OpenStack.
https://www.airshipit.org/
Apache License 2.0
78 stars 35 forks source link

Armada executes tests with any value not "false" for the `test:` key in a chart definition #190

Closed wilkers-steve closed 6 years ago

wilkers-steve commented 6 years ago

Is this a bug report or feature request? (choose one): bug

Python Version (output of python --version):

Development or Deployment Environment?:

Release Tag or Master: Master

Expected Behavior: Armada should only execute tests for a chart with the test: key set to true

What Actually Happened: Armada executes tests with any not "false" value set for the test: key

How to Reproduce the Issue (as minimally as possible): Set the test: key to foo and apply your manifest

Any Additional Comments:

Chart definition:

schema: armada/Chart/v1 metadata: schema: metadata/Document/v1 name: elasticsearch data: chart_name: elasticsearch release: elasticsearch namespace: osh-infra timeout: 3200 test: foobar install: no_hooks: false upgrade: no_hooks: false values: labels: node_selector_key: openstack-control-plane node_selector_value: enabled storage: filesystem_repository: enabled: false elasticsearch: enabled: false conf: elasticsearch: repository: enabled: false manifests: pvc_snapshots: false job_snapshot_repository: false source: type: local location: "../openstack-helm-infra/" subpath: elasticsearch reference: master dependencies:

Output:

2018-01-25 13:41:50.966 31574 INFO armada.handlers.chartbuilder [-] Building dependency chart osh-infra-helm-toolkit for release elasticsearch. 2018-01-25 13:41:51.014 31574 INFO armada.handlers.armada [-] Installing release elasticsearch 2018-01-25 13:41:51.017 31574 INFO armada.handlers.tiller [-] Wait: True, Timeout: 3200 2018-01-25 13:42:15.583 31574 INFO armada.handlers.armada [-] Testing: osh-elasticsearch 2018-01-25 13:42:16.643 31574 INFO armada.handlers.armada [-] Test INFO: started_at { seconds: 1516909335 nanos: 610444478 } completed_at { seconds: 1516909335 nanos: 721291089 } results { name: "osh-elasticsearch-test" status: FAILURE info: "pods \"osh-elasticsearch-test\" already exists" started_at { seconds: 1516909335 nanos: 610893412 } completed_at { seconds: 1516909335 nanos: 721290086 } }

2018-01-25 13:42:16.656 31574 INFO armada.handlers.armada [-] PASSED: osh-elasticsearch

wilkers-steve commented 6 years ago

Addressed with: https://review.gerrithub.io/#/c/396477/

Closing this issue out