search

att-comdev / armada

This project has moved to OpenStack.
https://www.airshipit.org/
Apache License 2.0
78 stars 35 forks source link

Tiller service and replicaset are in different namespaces #193

Closed hemanthnakkina-zz closed 6 years ago

hemanthnakkina-zz commented 6 years ago

Is this a bug report or feature request? (choose one): BUG REPORT

Python Version (output of python --version):

Development or Deployment Environment?: Deployment Environment

Release Tag or Master: Master

Expected Behavior: Tiller service is expected to be created on kube-system namespace

What Actually Happened: Deployed UCP using promenade genesis script with tiller namespace as kube-system. tiller pod is deployed on kube-system namespace but tiller service and endpoint are deployed on ucp namespace

How to Reproduce the Issue (as minimally as possible): Tiller schema used in deployment

schema: armada/Chart/v1 metadata: schema: metadata/Document/v1 name: tiller layeringDefinition: abstract: false layer: site storagePolicy: cleartext data: chart_name: tiller release: tiller namespace: kube-system install: no_hooks: false upgrade: no_hooks: false values: images: tags: tiller: gcr.io/kubernetes-helm/tiller:v2.7.2 labels: node_selector_key: ucp-control-plane node_selector_value: enabled source: type: git location: https://github.com/att-comdev/armada subpath: charts/tiller reference: master dependencies:

Any Additional Comments:

kubectl get pod --all-namespaces | grep tiller kube-system tiller-deploy-68fc946984-xf46t 1/1 Running 0 1d

kubectl get svc --all-namespaces | grep tiller ucp tiller-deploy ClusterIP 10.96.160.81 44134/TCP 1d

kubectl get endpoints --all-namespaces | grep tiller ucp tiller-deploy 1d

kubectl get serviceaccounts --all-namespaces | grep tiller kube-system tiller-deploy 1 1d

hemanthnakkina-zz commented 6 years ago

Some more additional information that triggered the above error. Following armada chart is also deployed as part of genesis.sh script invokation

schema: armada/Chart/v1 metadata: schema: metadata/Document/v1 name: armada layeringDefinition: abstract: false layer: site storagePolicy: cleartext data: chart_name: armada release: armada namespace: ucp install: no_hooks: false upgrade: no_hooks: false values: manifests: deployment_tiller: false service_tiller: false images: tags: api: quay.io/attcomdev/armada:latest labels: node_selector_key: ucp-control-plane node_selector_value: enabled network: api: node_port: enabled: true port: 31903 source: type: git location: https://github.com/att-comdev/armada subpath: charts/armada reference: master dependencies:

The above mentioned problem is caused by 2 issues

  1. tiller-service creation in ucp namespace

    The armada manifest have wrong tiller service name service_tiller: false instead of service_tiller_deploy: false As default value for service_tiller_deploy is true, this creates a tiller-service in ucp namespace (Deployment mistake - not source code error)

  2. tiller-service not created in kube-system namespace

    The tiller chart by default enabled the following manifests service_tiller: true. This should be service_tiller_deploy: true Fix for this available @ https://review.gerrithub.io/#/c/398900/