att-comdev / halcyon-kubernetes

Ansible playbooks for a kubadm-based kubernetes deployment, on supporting any cloud and any kubeadm-enabled OS.
Apache License 2.0
35 stars 22 forks source link

Update CentOS install to use upstream docker #17

Closed intlabs closed 7 years ago

intlabs commented 7 years ago

This commit updates deploy-kube to use the upstream docker rpm from the docker repo, as the current docker in the CentOS repos is lagging behind and has some performance issues.

intlabs commented 7 years ago

Cheers, having the kubeadm lot looking after docker would make things a lot easier :) I wasn't sure what the intention was here - as ansible was setting up the docker repo, but the version installed was from the CentOS updates repo. For some reason with either version of docker I've been getting pretty horrible performance on CentOS in my VMs under libvirt, but suspect it could be just me... I've got the performance back to acceptable over here: https://github.com/portdirect/halcyon-kubernetes/commit/728057aa6eb392af83d86bcde3f80e5be774f44e, but I don't think it's appropriate to make a PR considering your requirements and because I've not got the ability to test this on anything other than my workstation atm.

v1k0d3n commented 7 years ago

Good catch! I'll try to test against your changes next week. If it helps performance, is something we can track with relative ease (perhaps this resolves itself over time with improvements), I'd be happy to accept a PR. We've been working with Ubuntu primarily on our end, so this issue has been off our radar. I'd like this repo to be useful for a wide audience, so I'm really glad you brought it up!