Fix issues with proxy support

att-comdev / halcyon-vagrant-kubernetes

Vagrant deployment mechanism for halcyon-kubernetes.

Apache License 2.0

12 stars 14 forks source link

Closed mwgiles closed 7 years ago

mwgiles commented 7 years ago

Several fixes to better support running behind a proxy

Fix mistyped variable name when checking proxy_enable
Don't override the config file's settings for proxy_no variable
Pass proxy values into ansible. These values are required for a forthcoming change to halcyon-kubernetes in order to create a docker proxy config file

mwgiles commented 7 years ago

See https://github.com/portdirect/halcyon-kubernetes/pull/1 for the change to halcyon-kubernetes that makes use of the proxy values being passed into ansible.

wilkers-steve commented 7 years ago

This looks good to me. Going to close this out and merge it in. Thanks @mwgiles!