search

att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

Fixed copyright headers for rabbitmq erlang templates #238

Closed mattmceuen closed 7 years ago

mattmceuen commented 7 years ago

What is the purpose of this pull request?: To convert the copyright headers on the rabbitmq erlang templates to erlang-style comments, and remove the header from the cookie file.

What issue does this pull request address?: Fixes #237

Notes for reviewers to consider:

Specific reviewers for pull request: jallirs

v1k0d3n commented 7 years ago

@mattmceuen good catch. someone warned me about this at the PTG, and I was going to get to it today. your PR is pretty timely; thanks for submitting.

LGTM.

if I get someone else to approve it, i'll merge it in.

@alanmeadows

wilkers-steve commented 7 years ago

This LGTM. TravisCI is happy with it, so I am too.

v1k0d3n commented 7 years ago

thanks @wilkers-steve. since this is a bugfix, rather than a feature enhancement i will merge it in.