search

att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

Disable service replicas with development mode flag #265

Closed wilkers-steve closed 7 years ago

wilkers-steve commented 7 years ago

Disable service replicas with development mode flag in all charts

To remain consistent with other services, this adds a development mode flag to reduce the number of replicas to 1.

What is the purpose of this pull request?: Disables replicas for a service when development flag is set to enabled

What issue does this pull request address?: Partially addresses #258

Notes for reviewers to consider:

Specific reviewers for pull request:

wilkers-steve commented 7 years ago

@v1k0d3n @intlabs related to our discussion re: rethinking development mode, do we want to close this PR out? After some thought, I'm not a fan of the idea of controlling replicas with a development flag.

v1k0d3n commented 7 years ago

yup, i'll let you close it out. i think that if we just stick with a developer focused config-override on the client side, rather than with debt in the form of conditionals we'll be in a lot better shape (imo, and as we've discussed collectively).

wilkers-steve commented 7 years ago

Absolutely agreed. :+1: