search

att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

LVM backend support for Cinder #300

Closed wilkers-steve closed 7 years ago

wilkers-steve commented 7 years ago

Initial commit for adding LVM support for Cinder. Adds necessary configuration files for supporting configuration of the backend

What is the purpose of this pull request?: Add support for LVM backend for Cinder

What issue does this pull request address?: Fixes #293

Notes for reviewers to consider:

Currently the configmaps for the LVM backend aren't handled with conditionals. This will change before the WIP tag gets removed.

Specific reviewers for pull request:

v1k0d3n commented 7 years ago

this is actually started as part of the development mode overrides (or improvement of development workflow), so it is an item on the 0.3.0 roadmap.

wilkers-steve commented 7 years ago

@alanmeadows @v1k0d3n @intlabs I've changed the mounts to function similarly to #319. The only snowflake was cinder-volume, but we can address how to conditionally handle backend-specific mounts as we move forward

v1k0d3n commented 7 years ago

@wilkers-steve is PR this in or out for openstack?

wilkers-steve commented 7 years ago

@v1k0d3n I would say it could go either way. I wouldn't let this block the -1 workflow on the patchset for moving into OpenStack. If I get the iscsi bits added before the +2 happens for moving into infra, we can go ahead and merge it in. If it doesn't, I'll add the work in once we move into OpenStack

wilkers-steve commented 7 years ago

Lets get this in once we're in OpenStack.

v1k0d3n commented 7 years ago

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm