search

att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

fixes #311: Glance ceph.enabled has no effect #312

Closed dulek closed 7 years ago

dulek commented 7 years ago

What is the purpose of this pull request?: Fixing ceph.enabled having no effect on glance-api.conf and causing any image upload to fail without Ceph.

What issue does this pull request address?: Fixes #311

Notes for reviewers to consider:

Specific reviewers for pull request:

v1k0d3n commented 7 years ago

good catch on this one too @dulek. @alanmeadows what is the status of your configuration overrides solution for glance?

v1k0d3n commented 7 years ago

@dulek i think we're going to hold off on this PR until we're in openstack (next week). once we're there, @alanmeadows configuration overrides should really change the landscape, and development mode is out in favor of overrides and other tooling. we'll document these in the developer docs soon after our import into openstack.

once you confirm, i'll mark with a flag of "do not merge" just so we know what's in and out. does that work for you?

dulek commented 7 years ago

@v1k0d3n: Sure thing, this definitely collides with Glance conf override.

v1k0d3n commented 7 years ago

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm