att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

Standardize Labels (name:value pair) & Replica to align with other charts #326

Open renmak opened 7 years ago

renmak commented 7 years ago

Is this a bug report or feature request? (choose one): Mixed; depends on perspective

Kubernetes Version (output of kubectl version): N/A

Helm Client and Tiller Versions (output of helm version): N/A

Development or Deployment Environment?: N/A

Release Tag or Master:

Expected Behavior: As a developer and operator, it would be desirable to have standardized value.yaml in all charts.

Nova and Neutron are considered as a sample standard helm chart.

In following charts, Labels needs to be separated (just like replicas) to achieve parity with Nova & Neutron Cinder, Ceph, Glance, Heat

What Actually Happened: This is what we have today in Cinder value.yaml

replicas:
  api: 1
  volume: 1
  scheduler: 1

labels:
  node_selector_key: openstack-control-plane
  node_selector_value: enabled

How to Reproduce the Issue (as minimally as possible):

Any Additional Comments: @v1k0d3n @alanmeadows

renmak commented 7 years ago

Created this new issue to track pending standardizing work.

Following are previous issues related to this issue

267

207

wilkers-steve commented 7 years ago

@renmak Thanks for tracking your work and thinking about services outside of what you've tackled in nova. In regards to standardizing our charts, I think nova and neutron were the only two that needed special consideration. That need arose out of both services having some components that run on the control plane and some components that run on the compute nodes.

I don't think we should define a label for each component in the rest of the services as they'll all run in the control plane. I'd like @alanmeadows feedback on this, but I think nova and neutron should be the only two that needed attention.