att-comdev / openstack-helm

PROJECT HAS MOVED TO OPENSTACK
https://github.com/openstack/openstack-helm
69 stars 41 forks source link

Add default dns server in dhcp agent conf. #337

Closed akorzeni closed 7 years ago

akorzeni commented 7 years ago

When running simple VXLAN network, VMs does not have access to DNS. The dhcp agent pod configuration is pointing to k8s dns, but dnsmasq agent does not have access to it within its namespace. Due to security reasons, it should not have access to k8s underlay infra, so adding generic 8.8.8.8 DNS server address.

What is the purpose of this pull request?: Add default DNS server for simple DHCP agent configuration.

What issue does this pull request address?: When installing OpenStack-Helm out of the box, creating the simple VXLAN network without specifying DNS server while creating subnet, VMs launched would not have access to the DNS server.

Notes for reviewers to consider: Adding hardcoded 8.8.8.8 to the DHCP agent config. It maybe good to add it as config option.

Specific reviewers for pull request:

v1k0d3n commented 7 years ago

closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm