search

att-comdev / promenade

This project has moved to OpenStack.
https://www.airshipit.org/
Apache License 2.0
11 stars 15 forks source link

Touch file so drydock doesn't run script twice #18

Closed mark-burnett closed 7 years ago

mark-burnett commented 7 years ago

@jezogwza Are you asking to verify that touch executed correctly?

jezogwza commented 7 years ago

No I am asking to verify that promenade join operation executed successfully before we touch the file. That of course would have value if there are scenarios or cases when a retry (rebooting one more time) might yield success.

mark-burnett commented 7 years ago

@jezogwza I agree validating nodes is important. In fact, running join multiple times is potentially OK, but not the immediate intent, so I would be somewhat hesitant to try it as a recovery mechanism for the moment.

In the long term, I suspect we might be able to leverage shipyard to orchestrate node validation steps, but we are not there yet.

Do you think we need to add validation as part of this PR?

jezogwza commented 7 years ago

Not for what we are trying to do short term. For the long term solution I believe we do. QQ , How does DryDock have a mechanism to determine that the server worked fine? Does it run i.e a kubectl -- something

mark-burnett commented 7 years ago

@jezogwza Thanks for looking, I will go ahead and merge this.

Re: DryDock validation

Good question -- I do not believe it does yet, but certainly @sh8121att would know.

sh8121att commented 7 years ago

@jezogwza Currently Drydock has no feature to validate anything because once a server is booted, it has no mechanism to effect change. Long term I could see Drydock using the Kubernetes API to validate newly booted node is now part of the cluster simply for reporting purposes. It still won't have any ability to fix it (aside from redeploying the node)