att-comdev / prometheus-openstack-exporter

Apache License 2.0
29 stars 19 forks source link

Hypervisors aren't mapped to aggregates because of shortname/FQDN mismatch #7

Open jralbert opened 6 years ago

jralbert commented 6 years ago

In the hypervisor_stats collector, a list of aggregates is assembled, and then each hypervisor is compared against each aggregate's membership list to identify whether the hypervisor is a member of the aggregate. However, aggregate memberships are stored and returned as shortnames, while the hypervisor name is an FQDN (at least in my OpenStack-Ansible-deployed OpenStack); so no hosts are ever mapped to any aggregates.

If the project maintainers agree, I will propose a PR stripping the shortname out of the hypervisor FQDN for the purposes of comparing aggregate membership; this could be controlled by a configuration option if necessary.

damianbulira commented 5 years ago

Hi @jralbert, please do propose, I would be happy to apply this for myself.