search

att / rcloud.dcplot

Dimensional charting (dc.js) for RCloud
6 stars 7 forks source link

arrays containing negative numbers not parsed properly #14

Open gordonwoodhull opened 9 years ago

gordonwoodhull commented 9 years ago

From @gordonwoodhull on February 4, 2014 21:20

The wdcplot parser is not expecting expressions within c(...).

It should parse the values in the ordinary tree way instead of assuming plain string/numeric values.

Copied from original issue: att/dcplot.js#5

gordonwoodhull commented 9 years ago

I think the problem is right here:

            else if(sexp[0]==='c')
                    return sexp.slice(1);
            // else we'll process as expression below

https://github.com/att/rcloud.dcplot/blame/master/inst/www/wdcplot.js#L232

No, just always process as expression.

And here's the possibly-errant commit (1/1/2014), which looks like it was going in the right direction but didn't go far enough: att/rcloud@0eec64fe8729977f9600f10710444f0bc06d062f

Extensive changes to expression processing on JS side - needs further testing, but far more robust in principle.

Har, har.