search

att / rcloud.shiny

Shiny support for RCloud
Other
4 stars 12 forks source link

Add shiny-specific code from rcloud to this package, FIX #7 #19

Closed useless5771 closed 7 years ago

useless5771 commented 7 years ago

This change depends on https://github.com/att/rcloud/pull/2435

gordonwoodhull commented 7 years ago

Good work! This works great. Nice relief to have this cleaned up.

Now we just have to think about the consequences.

Please do a version bump on this package to 0.5, and require rcloud.support (>= 1.8-1)

Also I'm concerned that loading this package as an addon will pull Shiny into every session, so could you look into lazy-loading shiny, by Suggesting it instead of Depending it, and loading the library once it's needed?

This is actually a design flaw in RCloud addons: we load the whole package when all we're doing is adding a menu item. But I don't see us fixing this soon.

I wonder what else this changes.... Still, it needs to be done.

useless5771 commented 7 years ago

Ok, thanks, I will make these changes.

useless5771 commented 7 years ago

Ok, rearranged dependencies and made rcloud.shiny dependent on rcloud.support (>=1.8-0) as this the current version on both develop and hotfix-1.8.1 branches.

gordonwoodhull commented 7 years ago

rebased and merged

gordonwoodhull commented 7 years ago

Thanks @useless5771!