search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
432 stars 142 forks source link

view/mini.html show &tag= instead of &version= when there's a tag #1037

Open gordonwoodhull opened 10 years ago

gordonwoodhull commented 10 years ago

edit.html shows &tag=xxx instead of &version=xxx when there is a tag for the current version.

The rationale is that if you are viewing a tagged version, if you bookmark or share the link, you will want to go back to the tag even if it gets reassigned. Also, tags are prettier. :-)

However, view.html and mini.html do not have this implemented yet. Not sure if I'll get to this for today's release, so opening a ticket.

sujitbehera27 commented 9 years ago

@gordonwoodhull This is fixed I suppose. I was just testing and can see tags in both view as well as mini.html http://127.0.0.1:8080/view.html?notebook=8fe5406659540f8c1a4f&tag=testleaf http://127.0.0.1:8080/mini.html?notebook=8fe5406659540f8c1a4f&tag=testleaf Let me know if I failed to understand the issue here.

gordonwoodhull commented 9 years ago

@sujitbehera27, it works when you are opening it from edit.html because we fixed #1044 shareable link using tags.

However, if you explicitly load a view.html or mini.html page using &version=... and the version is tagged, it doesn't automatically change the URL to show the tag, the way edit.html does. That's what this ticket is about.

souravkjha commented 9 years ago

I will work on this.

souravkjha commented 9 years ago

Behavior : 1> For edit.html if user selects version for a tagged notebook, url automatically changes to tag if it was tagged. 2> Same should work for view.html and mini.html.

Design : 1> Find the mapping of version and tag. 2> change the version to tag change logic in mini.js and view.js same as that of edit.js. 3> Load changed url which contains tag in place of version if there is a tag available for that version.

gordonwoodhull commented 9 years ago

Sounds good, @souravkjha.

Just to clarify, it's not necessary to load any new page; we can use the same html5 history api edit.html uses, to change the URL without loading anything.

souravkjha commented 9 years ago

This has been fixed, PR #1155 has been raised.

gordonwoodhull commented 9 years ago

Patch was delivered, looks correct but still needs careful review. Deferring this issue.