Something stronger than SIGINT

att / rcloud

Collaborative data analysis and visualization

http://rcloud.social

MIT License

430 stars 141 forks source link

Something stronger than SIGINT #1089

Open gordonwoodhull opened 9 years ago

gordonwoodhull commented 9 years ago

Now that we have a Stop button, people will expect it to work, always.

People have lower expectations for ctrl-C imho. It's just a keystroke and we know it may take a moment. But a button feels immediate and we feel like it should really stop, or it should reflect that it's trying to stop, or it should maybe offer harsher remedies like SIGKILL.

s-u commented 9 years ago

like "stop" and "really stop"? ;)

Yes interrupts in R are cooperative, i.e. they are only signaled, but the code has to enter a safe point before they are honored - and packages that don't check interrupts in their C code will prevent interrupts.

Maybe the first click is INT and the icon changes to something like skull and bones at which point another klick kills the session.

I'm not sure if it's a UI issue (just need better visual feedback that stop was signaled just not honored yet) or a terminate-vs-interrupt issue.

gordonwoodhull commented 9 years ago

That sounds good. Retitling and labeling as enhancement

I haven't yet seen the problem myself, guess I need an uncooperative C library to test it.

I suggest:

Icon turns to something animated while it's trying to interrupt. Maybe a throbbing square.
Tool tip now says Kill.
Clicking again brings up confirmation dialog: do you really want to kill your session?
Killing needs to both send the stronger signal and immediately create a new session. Shouldn't be too hard but not trivial.