search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
431 stars 141 forks source link

Firefox: Misaligned check boxes #1957

Open prateek032 opened 8 years ago

prateek032 commented 8 years ago

This issues is observed on the latest Firefox version (46.0). For example: In setting div

image

shaneporter commented 8 years ago

It's ok on Firefox 45.0.1, Ubuntu:

image

I'll upgrade and take a look.

Update: Yep, Firefox 46 checkboxes are massive.

shaneporter commented 8 years ago

I have looked at Firefox 46 checkboxes on Windows, and they are 'normal'. Unable to check on Mac, but regardless of that platform's rendering, we have an issue.

I can't think of an alternative to styling checkboxes across platforms/browsers.

It seems all styling/JavaScript solutions require a particular structure of label and input (there are 2 alternatives as I recall.) I'd have to go through and verify that all are using a particular structure, because if not, they will not be visible.

gordonwoodhull commented 8 years ago

Weird, why would they make them so large on one platform only? Of course it is okay in Firefox 46 on OSX.

We always do <label><input ...></input> Label text</label>, or I think we always do. That allows you to click on the text to invoke the checkbox.

There's probably a trivial CSS trick we can do - but if not, I think we can safely chalk this up as a browser bug.

shaneporter commented 8 years ago

Yes, as far as I can see, it's a browser issue, since it's not reproducible on other OSs or previous versions of Firefox on Ubuntu.

gordonwoodhull commented 8 years ago

This happens also on Chrome and Safari on iOS. image

shaneporter commented 8 years ago

Oh dear.