accidental globals from editor_tab refactor

att / rcloud

Collaborative data analysis and visualization

http://rcloud.social

MIT License

430 stars 142 forks source link

accidental globals from editor_tab refactor #2590

Closed gordonwoodhull closed 5 years ago

gordonwoodhull commented 6 years ago

I noticed that username_ and current_ are not defined in editor_tab.js, so JavaScript has promoted them to global variables.

Don't have time/patience at the moment to find the right tool to lint all our code for this. (Thought jshint would do this, but it's curiously silent about this problem.)

gordonwoodhull commented 5 years ago

Fixed in #2623