search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
431 stars 142 forks source link

enter doesn't work everywhere in merge and apply dialogs #2601

Closed gordonwoodhull closed 6 years ago

gordonwoodhull commented 6 years ago

The default action, either proceeding to the next dialog or applying the changes, should be invoked when pressing enter anywhere in the dialog (except the dropdowns).

However, when the Notebook ID input has the focus, or the Monaco editor has the focus, enter has no effect.

jameesy commented 6 years ago

I will be more than happy to look at this Gordon. It gives me a good chance to get familiar with the merge dialogue code.

gordonwoodhull commented 6 years ago

Thanks @JABedford, this is a great place to start. Filing a PR on this will be a good practice run.

I've invited you to the repo so I can assign issues to you, but until I do that, please feel free to take any open 2.1 issues.