att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

Bugfix/Issue-2577 #2610

Closed jameesy closed 5 years ago

jameesy commented 5 years ago

The this.$tree_ is undefined error was eventually found to be being triggered by selecting the same notebook from a different directory.

Assigning "this" to a new variable fixes the issue.

gordonwoodhull commented 5 years ago

Makes sense. That looks like it would break every time, wonder why it ever worked.

Thanks @JABedford!

gordonwoodhull commented 5 years ago

One little trick you can do that will help me out, is to include fixes #xxx or closes #yyy in your commit messages when they solve an issue. GitHub will automatically close issues when it sees certain messages in commits that are merged to the default branch.