att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

Error: a.gistname is undefined; can't access its "localeCompare" property #2617

Open gordonwoodhull opened 5 years ago

gordonwoodhull commented 5 years ago

Fresh session, created a notebook and renamed it to put it in a folder (rcloud.params/mats new api)

Got the above error. Tried creating another notebook and wasn't able to repro, but returning to the same notebook I still got the same error.

Made a change to the notebook, got the same error again. But when I reload the page and then open the notebook again, it is okay and the change was saved.

It's clearly a superficial error in the notebook tree sort somewhere.

Error: a.gistname is undefined; can't access its "localeCompare" property
TypeError: a.gistname is undefined; can't access its "localeCompare" property
    compare_nodes@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14043:25
    find_sort_point@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14462:30
    insert_in_order@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14488:26
    update_tree@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14846:28
    update_tree_entry@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14997:24
    update_notebook_view@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14434:21
    update_notebook_from_gist/<@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14309:28
From previous event:
    update_notebook_from_gist@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:14308:18
    update_notebook_from_gist@http://minimonolith.dev.local:8080/js/rcloud_bundle.js:16188:20
    load_callback/</</<@http://minimonolith.dev.local:8080/editor_tab.js:780:48
From previous event:
    load_callback/</<@http://minimonolith.dev.local:8080/editor_tab.js:779:41
From previous event:
    load_callback/<@http://minimonolith.dev.local:8080/editor_tab.js:762:24
From previous event:
    load_notebook/<@http://minimonolith.dev.local:8080/editor_tab.js:158:22
From previous event:
    load_notebook@http://minimonolith.dev.local:8080/editor_tab.js:156:20
    open_notebook@http://minimonolith.dev.local:8080/editor_tab.js:184:17
    click_recent@http://minimonolith.dev.local:8080/editor_tab.js:573:19
    dispatch@http://minimonolith.dev.local:8080/lib/js/jquery-2.1.1.js:4408:15
    add/elemData.handle@http://minimonolith.dev.local:8080/lib/js/jquery-2.1.1.js:4095:6
gordonwoodhull commented 5 years ago

We got a similar error a very long time ago in #701 - looks like it may be the same cause, notebook with same name as notebook folder. (FWIW this time the offending notebook was not starred, so I only saw it in All Notebooks, not Notebooks I Starred.)