Accidental Globals in editor_tab.js.

att / rcloud

Collaborative data analysis and visualization

http://rcloud.social

MIT License

430 stars 142 forks source link

Accidental Globals in editor_tab.js. #2623

Closed jameesy closed 5 years ago

jameesy commented 5 years ago

Fixes #2590

Is incorporating a tool something we are looking at doing immediately @gordonwoodhull ? ESLint seems to be the most popular choice currently. Perhaps we could create a new dedicated issue to discuss further?

gordonwoodhull commented 5 years ago

Thanks @JABedford.

Ah the whims and fads of Javascript... Yes ESLint sounds good.

Sure, I'll open another issue.

gordonwoodhull commented 5 years ago

Thanks @JABedford, merged for 2.1