gordonwoodhull
commented
5 years ago Yeah, I don't completely understand package-lock.json; I end up having to replace it a lot.
This is a great start and it's finding a lot of the stuff that worries me. Wow we have lots and lots of undefined variables. Some of them are really concerning, like how does anything work if $tree_ is sometimes a member and sometimes a global?
It's still warning about a lot of trivial, stylistic things, like unused function parameters, uses of the console (yes, we use the console, what of it? ;) and extra semicolons.
I may have to do a lot of the cleanup since I know how things are supposed to work. But if you could do a quick pass in a second PR, disabling some of the silly warnings and declaring the obvious undeclared variables, that will help a lot.
I'll go ahead and merge this. Thanks @JABedford!
ESLint installed with all the dependencies it requires and a very basic config file set up. Really the only things this is searching for are undeclared variables (accidental globals), unused variables and more severe syntax issues.
For some reason npm threw a bit of a wobbly during installation and some dependencies got uninstalled - possibly due to this ongoing issue https://github.com/npm/npm/issues/17929 - however the last commit reinstalls the dependencies it removed.
Were you happy with the way this is all set up @gordonwoodhull for me to sweep the entire codebase and try and fix some of the issues?