search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

keep/ignore buttons shouldn't fade into Apply Changes dialog #2626

Closed gordonwoodhull closed 5 years ago

gordonwoodhull commented 5 years ago

Ideally all of the UI in the Apply Changes dialog should be shown immediately when the dialog opens.

It looks like right now the UI displays, then space gets added in order to display the "Keep deleted content" / "Ignore added content" buttons, and then finally the buttons fade in.

These animations don't really add anything and I find them confusing. I understand that maybe the space needs to get added after the fact, but the buttons shouldn't fade in.

It's not like we are transitioning from a state where it makes sense not to have the buttons there.

jameesy commented 5 years ago

I agree the UX of these is misleading.

Seemingly we are not alone in thinking this @gordonwoodhull : https://github.com/Microsoft/vscode/issues/19917

Currently they are not able to be configured. I'll keep an eye on this though, surely with so many people crying out for this feature it will be implemented?

gordonwoodhull commented 5 years ago

Nods. It does sound like the problem is much deeper, in that they are relying on some lazy loading architecture in CodeLens which we don't need.

Thanks for finding this, and adding your voice to the chorus.

Eventually it may have been a mistake to use Monaco for this. I overestimated how much of the diff editor could be reused.

@shaneporter ended up reimplementing so much that we could have just figured out how to do annotations in Ace and it would have been easier.

If it had been possible to combine the side-by-side diff with CodeLens in Monaco it would have been worth it, but that didn't work.

Looking forward to someone open sourcing a three-way diff and merge UI for the web, but I don't think that has happened yet.