Merge Notebook from File tree triggers ReferenceError?

att / rcloud

Collaborative data analysis and visualization

http://rcloud.social

MIT License

430 stars 142 forks source link

Merge Notebook from File tree triggers ReferenceError? #2634

Closed dkey-pugh closed 5 years ago

dkey-pugh commented 5 years ago

When usig the Merge Here feature from the file tree instead of the Advanced menu, when the diff is displayed, the cell contents hang and the console shows "Uncaught ReferenceError: monaco is not defined at init". This blocks merger via this workflow.

gordonwoodhull commented 5 years ago

It's also possible to hit this by opening Advanced / Merge Notebook and pressing enter really quickly... basically Monaco is being loaded asynchronously by the Merge Changes dialog, instead of synchronously by the Apply Changes as one would expect.