search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

Merge Notebook from File Tree triggers ReferenceError. #2637

Closed jameesy closed 5 years ago

jameesy commented 5 years ago

The workflow from the tree bypasses the original Monaco require statement, therefore Monaco is undefined.

Not sure why it worked so well without it!!

gordonwoodhull commented 5 years ago

Thanks @JABedford, it looks like the first Merge Changes dialog was loading Monaco (?), so probably speeding through that dialog caused a race condition.

jameesy commented 5 years ago

Seems I was a bit hasty in thinking this had fixed the issue in its entirety. Will continue working on it.

gordonwoodhull commented 5 years ago

Right, this will still load monaco in parallel - I think everything needs to go in the require callback unfortunately.

gordonwoodhull commented 5 years ago

Replaced with same change at a higher scope. Thanks @JABedford!