build should fail immediately when rcloud.support fails to build

att / rcloud

Collaborative data analysis and visualization

http://rcloud.social

MIT License

430 stars 142 forks source link

build should fail immediately when rcloud.support fails to build #2651

Closed gordonwoodhull closed 4 years ago

gordonwoodhull commented 5 years ago

This is the package which is most likely to fail due to missing prerequisites.

There is no point in continuing if rcloud.support fails to build, and if the build continues it just buries an important message.

Noobs unfamiliar with build systems don't know to search for the first error rather than trying to read the log backward, so they just see that something else failed due to no rcloud.support.

s-u commented 4 years ago

build.sh should check error codes of things it does