att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

display host in debug log #2663

Closed gordonwoodhull closed 4 years ago

gordonwoodhull commented 5 years ago

When RCloud is behind a load balancer and some nodes are faulty, an error can appear (unable to load notebook for example) before it is possible for the notebook to log the machine it's on.

It would be helpful to send the actual hostname as soon as the session is established.

Maybe just logging the welcome message is sufficient.

gordonwoodhull commented 5 years ago

One difficulty here is that the welcome message received for anonymous_session_init is not customized for the install (so it doesn't include the hostname).

However, the message can be seen inside of mini.js RCloud.create on_connect handler (hello)

gordonwoodhull commented 4 years ago

Related issue: if proxy.R fails to connect to the node hosting the session (e.g. because of a libcurl version mismatch), we don't know which node proxy.R is running on. (Will be handled in #2693.)