search

att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

editing a notebook with no description can crash #2680

Open gordonwoodhull opened 4 years ago

gordonwoodhull commented 4 years ago

The RCloud GUI does not allow you to create notebooks with blank descriptions, but if you directly create a notebook with e.g.

rcloud.create.notebook(list(files=rcloud.get.notebook("deadbeef",source="source", raw=TRUE)$content$files))

and then try to edit it, you can get errors like

Error: attempt to set info no description
at Object.rcloud.set_notebook_info (https://rcloud-server/js/rcloud_bundle.js:648:57)
at notebook_tree_model.add_notebook_info (https://rcloud-server/js/rcloud_bundle.js:14402:28)
at https://rcloud-server/js/rcloud_bundle.js:14430:22
From previous event:
at notebook_tree_model.update_notebook (https://rcloud-server/js/rcloud_bundle.js:14423:51)
at notebook_tree_model.update_notebook_from_gist (https://rcloud-server/js/rcloud_bundle.js:14444:25)
at notebook_tree_controller.update_notebook_from_gist (https://rcloud-server/js/rcloud_bundle.js:16342:32)
at https://rcloud-server/editor_tab.js:786:65
From previous event:
at https://rcloud-server/editor_tab.js:785:41
From previous event:
at https://rcloud-server/editor_tab.js:768:39
at cb_ (https://rcloud-server/js/rcloud_bundle.js:4278:28)
From previous event:
at Object.save (https://rcloud-server/js/rcloud_bundle.js:4794:18)
at https://rcloud-server/js/rcloud_bundle.js:4496:24
×
Error: incomplete notebook entry (has it been shown yet?)
at notebook_tree_model.as_folder_hierarchy (https://rcloud-server/js/rcloud_bundle.js:14277:19)
at notebook_tree_model.update_tree_entry (https://rcloud-server/js/rcloud_bundle.js:15148:35)
at notebook_tree_model.update_notebook_view (https://rcloud-server/js/rcloud_bundle.js:14573:26)
at https://rcloud-server/js/rcloud_bundle.js:14448:33
From previous event:
at notebook_tree_model.update_notebook_from_gist (https://rcloud-server/js/rcloud_bundle.js:14447:18)
at notebook_tree_controller.update_notebook_from_gist (https://rcloud-server/js/rcloud_bundle.js:16342:32)
at https://rcloud-server/editor_tab.js:786:65
From previous event:
at https://rcloud-server/editor_tab.js:785:41
From previous event:
at https://rcloud-server/editor_tab.js:768:39
at cb_ (https://rcloud-server/js/rcloud_bundle.js:4278:28)
From previous event:
at Object.save (https://rcloud-server/js/rcloud_bundle.js:4794:18)
at https://rcloud-server/js/rcloud_bundle.js:4496:24