att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

clicking on head version in tree does not remove &version from URL #2687

Closed gordonwoodhull closed 4 years ago

gordonwoodhull commented 4 years ago

Open the history on a notebook, click on an older version.

Then click on the main entry, returning to the head / most recent version.

Head version is loaded correctly, however the URL is not changed, so if you reload, you'll go back to an old version.

gordonwoodhull commented 4 years ago

It's worse, actually the version in the URL does not get updated once it is set - once you click on a historic version, the parameter is stuck there.

This is a consequence of 64c09de3d36 which attempts to retain any "extra" query string parameters. However, it ends up overriding any current parameters with the old ones... unless the notebook itself changes (which is probably why we didn't notice this earlier).