gordonwoodhull
commented
4 years ago Demo in the above commit needs
- [x] to check at load not just on scroll
- [x] throttling or wait until scrolling has stopped, so it doesn't backlog if you're scrolling fast through the notebook
- [x] remove the edit mode button
- [x] put behind an option so that people on slow computers can disable if it causes new stalling
As far as I can remember, edit mode is just a performance hack because we couldn't spawn that many ace editor windows without stalling the browser.
It causes a lot of glitches with font rendering and clicks not landing quite where they were aimed.
Maybe the performance would be okay if the cost were spread out? I am experimenting on a branch with a lazy-load mechanism, and it is promising.
At the start of session, and whenever there is a scroll event,On a 100ms interval, when scrolling has stopped, we'll check which cells are in view, and activate those. The edit mode button will be removed.Note that the static view is still needed in order to fill in the right amount of vertical space and show a placeholder during the ~50ms it takes each cell to activate (as well as for read-only mode).
Opening this issue in case anyone can think of drawbacks to this approach.
This will make #2682 even more important, because we don't want ghost cursors in every cell.