att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

auto-resize causes Uncaught TypeError: Cannot read property 'top' of undefined #2700

Open gordonwoodhull opened 4 years ago

gordonwoodhull commented 4 years ago

I am unclear why .outer-ace-div does not exist in

                        var ace_div = $(renderer.$cursorLayer.element).closest('.outer-ace-div');

I don't like

-                        var ace_div = $(renderer.$cursorLayer.element).closest('.outer-ace-div');
+                        var ace_div = $(renderer.$cursorLayer.element).closest('.ace_editor');

especially since there is another copy of this code.

So unfortunately I am leaving this for now. It is mostly harmless.