att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

with autoactivation, edit button should just show/hide source in markdown cells #2701

Closed gordonwoodhull closed 4 years ago

gordonwoodhull commented 4 years ago

Thanks to @ra-mac for pointing out that auto-activation left no way for the source to be shown on a markdown cell once it was run.

As of RCloud 2.1, the edit button had two functions: it would activate edit mode, and, if the cell was markdown, it would also show the source if it was hidden.

The source of a markdown cell gets hidden when the cell runs.

With autoactivation, we remove the first function. To make it consistent with the show/hide results button, it will now hide as well as show the results, and the edit button will only be shown for markdown cells.

gordonwoodhull commented 4 years ago
image