att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

clarify/change "merge from" icon wording #2704

Closed s-u closed 4 years ago

s-u commented 4 years ago

The words "merge from" in the tooltip for the "merge into current notebook" feature are misleading. I wanted to merge changes from the current notebook into its parent so assumed clicking "merge from" on the current notebook is how to tell you want to do that (assuming that it will default the target notebook to be the parent - see #2703). However, "merge from" really means "merge into current" so the proper way is to switch the notebook and use "merge into current" - which is not obvious. Hence I'd suggest changing the tooltip to say "merge into current notebook" so it's obvious what it does - it was the original name of the feature after all ;).

gordonwoodhull commented 4 years ago

Wow. We sure have struggled with this one.

I guess you are right: there is no way to abbreviate the tooltip and we just need to spell it out.

s-u commented 4 years ago

The feature is very powerful, but non-trivial (merging never is trivial) - so we may need to spell it out.

(BTW: I'm starting to love this mindset of using notebooks as branches... don't get me too excited or I'll start thinking about branch networks ;))

gordonwoodhull commented 4 years ago

@jsseidel and I settled on verbose language when working on the docs. It was too confusing otherwise.

It would be really neat to have tools to deal with the tree of forks. These ideas go way back to #170. Technically with merging, it becomes a DAG, but we don't record merges in any special way, so we don't have the data.

gordonwoodhull commented 4 years ago

Here's a mockup of icon pointing from the notebook tree into current notebook for "merge into current notebook"

image

I couldn't figure out how to both rotate and flip the icon (this is icon-code-fork icon-rotate-270)