att / rcloud

Collaborative data analysis and visualization
http://rcloud.social
MIT License
430 stars 142 forks source link

MathJax URL in scripts/fetch-mathjax.sh seems to be broken #2711

Closed s-u closed 4 years ago

s-u commented 4 years ago

The MathJax URL used in scripts/fetch-mathjax.sh doesn't seem to yield working MathJax anymore. I had more luck with https://github.com/mathjax/MathJax/archive/2.7.7.tar.gz - but I wonder if it was just me or the repo truly changed.

gordonwoodhull commented 4 years ago

Confirmed and fixed, along with printing a warning rather than failing when MathJax is not present. (I think JS implementations got more strict about undefined variables since we started RCloud.)

It looks like it was a mistake to fetch a "branch" tarball (legacy) rather than a specific version, because it could change under us.

This is an issue you would only see on a brand-new install.