rcloud.conf option github.use.query.token

[gordonwoodhull]

Hi @s-u, here is the RCloud part of att/rgithub#3.

I have tested

• old RCloud works fine with new rgithub and rcloud-gist-services
• this change works fine with github.com as the backend and does not include the access_token query parameter it was complaining about

I have not tested this change with rcloud-gist-services.

[gordonwoodhull]

Based on feedback from @s-u, I changed the name from github.use.basic.auth to github.use.query.token, with the opposite meaning and opposite default; see also att/rgithub#4.

It also defaults the flag based on rational.githubgist.

Currently this requires one of those two to be set, since github.use.query.token defaults true like the rgithub setting.

We default it false at the RCloud level (even though defaulted true in rgithub for backward compatibility). So rcloud.conf is by default compatible with GitHub, although rgithub can’t be.

[gordonwoodhull]

@s-u, I think this and att/rgithub#4 satisfy your concerns.

If you have time to review, please give them a look.

[gordonwoodhull]

I'm merging this because I think it satisfies the concerns raised (and I got the deprecation warning again).

We can always revisit before release.