attachmentgenie / attachmentgenie-ufw

MIT License
21 stars 27 forks source link

ufw::logging is not idempotent #14

Closed igalic closed 11 years ago

igalic commented 11 years ago

when explicitly setting a log-level

  ufw::logging { 'explicitly-set-low-logging':
    level => 'low',
  }

ufw log 'level' will be executed on every puppet run:

pgdb01% i=1; while [[ $i -le 2 ]] ; do echo "run ${i}";  sudo puppet agent -t --debug | grep -i ufw::logging ; (( i++ )) ; done
run 1
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/require: requires Exec[ufw-default-deny]
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/before: requires Exec[ufw-enable]
Notice: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/returns: executed successfully
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]: The container Ufw::Logging[explicitly-set-low-logging] will propagate my refresh event
Debug: Ufw::Logging[explicitly-set-low-logging]: The container Class[Base::Firewall] will propagate my refresh event
run 2
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/require: requires Exec[ufw-default-deny]
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/before: requires Exec[ufw-enable]
Notice: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]/returns: executed successfully
Debug: /Stage[main]/Base::Firewall/Ufw::Logging[explicitly-set-low-logging]/Exec[ufw-logging-low]: The container Ufw::Logging[explicitly-set-low-logging] will propagate my refresh event
Debug: Ufw::Logging[explicitly-set-low-logging]: The container Class[Base::Firewall] will propagate my refresh event
pgdb01%