Closed DGriffin91 closed 2 months ago
Thanks for debugging and fixing this!
After re-reviewing #72 I'm wondering why I decided to merge without fixing this. I do recall hitting this exact problem while making the change. At one point I was going to allow submitting dynamic samplers using the render graph, but the code is left in a half-way state in between these ideas.
Making things worse, there are additional validation errors introduced with the latest Vulkan SDK which are fixed on an unpublished branch based on #75, so there will be errors related to swapchain and uint8 regardless.
One tiny edit I'll make is that the entire for
loop may be removed
The image_sampler example with
--separate
(with either hlsl or glsl) was resulting in this vulkan validation error:It was also crashing if run in render doc.
I think the sampler does not need to be updated in the descriptor binding in this case since it is already included immutably.
Sorry it took me so long to get around to testing this. Thanks so much for implementing it! Besides this issue it seems to be working great!