search

attah / harbour-seaprint

🐟🖨 Network printing for Sailfish OS
GNU General Public License v3.0
16 stars 20 forks source link

New Changes #51

Closed wheelseal closed 2 years ago

wheelseal commented 2 years ago
attah commented 2 years ago

Line 468: I don't see your suggestion as an improvement (in clarity) here. It does not just save your settings - it saves them as the default for future jobs. Without mentioning defaults, the user might think they need to save the settings before they print, which is not the case. If you still disagree, please expand your reasoning.

Line 557: I agree

Line 471: I actually think this information, especially the part in the %1, is quite important. Saved default settings (i.e. that are pre-applied to your next print-job) are separate for documents and pictures, which is not very obvious. Users might think saving settings is broken if they save them for a PDF, and then go to print a JPG and they are not there. If you still disagree, please expand your reasoning.

wheelseal commented 2 years ago

Line 468: I agree with you. I am so Sorry, it was a translation failure by me. I translated the button "Clear default settings" with "Standarteinstellung wiederherstellen" (in English "restore Default settings").

Line 471: I Agree at this point. I thought the same after I send my request to you. I think it is more visible (and also looks better) to give this hint the same font size as the buttons have. Or maybe integrade the %1 into the buttons. For Example: "Save as default settings for Documents".

attah commented 2 years ago

Regarding font size/color - that's what the theming from Jolla has for these things, i.e. it's automatic, and i won't make an effort to override it. This way it is consistent with other apps (not that very many use it). "Save as default settings for Documents" is probably too long in English even... then just think about German.

Please squash the commits, and keep only what you intend to ask to be changed. (Or start over if that is easier)

wheelseal commented 2 years ago

I didn´t know that is defoault size from Jolla. Now I understand your reason for that. I looked at it again and now have to say you are right, it would be very long in German.

"Please squash the commits, and keep only what you intend to ask to be changed. (Or start over if that is easier)" What do you mean?

What do you think about tho change the button "save default settings" to "Save as new default settings"? I think the different between old and new default setting would than more understandably.

attah commented 2 years ago

Now you have two commits with changes, part of which a mistake, that you are asking me to merge. https://github.com/attah/harbour-seaprint/pull/51/commits To fix the mistake you would have to add yet another commit to the stack... becoming pretty messy. Squashing is a term with a particular meaning in git.

"Save as new default settings", it could do with an "as", but "new" is just confusing (since it could imply that there are other non-new defaults to care about). There are no old or new default settings, just the default settings, which you can clear or replace.

wheelseal commented 2 years ago

Do you mean this with Squashing? But I think I'll close this request and always open a new one for any change.

attah commented 2 years ago

Yes, precisely. Good. But didn't we agree line 468 should remain unchanged?

attah commented 2 years ago

Done manually https://github.com/attah/harbour-seaprint/commit/77457ad61be349d30491dfc773e947841a1902d3