atteneder / KtxUnity

Load KTX and Basis Universal textures at runtime
Apache License 2.0
223 stars 42 forks source link

iOS libraries should be built with bitcode embedded #37

Closed push-pop closed 3 years ago

push-pop commented 3 years ago

Unity sets bitcode enabled by default. Since iOS binaries were not built with embedded bitcode, it requires turning off this setting manually or with a build postprocess in order to make an iOS build.

Would be great if we could have iOS binaries that have bitcode enabled so builds work with default settings.

Some info on benefits of Bitcode and why it's default in Unity: https://support.unity.com/hc/en-us/articles/209933103

How to build with Bitcode: https://stackoverflow.com/questions/31233395/ios-library-to-bitcode

atteneder commented 3 years ago

Hi @push-pop ,

Thanks for reaching out. I've done checks/tests and I think I can make bitcode work soonish.

cvetelinast commented 3 years ago

Hi, I have the same issue, any progress on this? The related issue seems to be closed, but this one is still open.

atteneder commented 3 years ago

Yes, it's actually not hard to add them, but I wanted to fix 2021.2 beta WebGL and Apple Silicon first. If I'm not making progress this week, I'll postpone those fixes and add bitcode first.

lhadzhipopov commented 3 years ago

Experiencing the same issue. Would really appreciate a fix. Thank you!

atteneder commented 3 years ago

Hi @lhadzhipopov ,

which version of KtxUnity are you using and how exaclty did you prove/certify that bitcode is missing?

I'm asking because this issue was supposedly fixed in KtxUnit 1.1.0 (which includes binaries from KTX-Software-Unity 0.4.1 where bitcode was added in 0.4.0). I just forgot to close this issue and now I'm confused why you're experiencing problems.

Regards, Andreas

daverin commented 3 years ago

Hi @atteneder

Also finding that 1.1.0 wasn't built with bitcode.

Xcode build logs (from Fastlane during archive):

Screenshot 2021-07-16 at 19 11 25
atteneder commented 3 years ago

@daverin Thanks for the report. I'll look into it

atteneder commented 3 years ago

Sorry for the wait and the confusion.

It should be fixed now in KtxUnity 1.1.1 (live anytime soon now)

Re-open the issue if you still have problems.

Thanks!