atteneder / glTFast

Efficient glTF 3D import / export package for Unity
Other
1.25k stars 251 forks source link

Asynchonous methods to not have Async suffix #665

Open StephenHodgson opened 10 months ago

StephenHodgson commented 10 months ago

Describe the bug

Asynchonous methods do not properly conform to the industry standard naming conventions for Task-based Async Pattern (TAP), which stipulate to add Async suffix to the name of the methods to clearly show that they are awaitable.

Asynchronous methods in TAP include the Async suffix after the operation name for methods that return awaitable types, such as Task, Task, ValueTask, and ValueTask.

StephenHodgson commented 10 months ago

Should be simple enough to add Async overload without introducing breaking changes.

atteneder commented 3 months ago

I don't disagree, but such changes bring the danger of breaking the API.

There's also no technical benefit, so this will be a low priority.