Fix packaging type in order to correctly provide OSGi bundle

atteo / classindex

Index classes, do not scan them!

Apache License 2.0

263 stars 43 forks source link

Fix packaging type in order to correctly provide OSGi bundle #52

Closed thjaeckle closed 5 years ago

thjaeckle commented 5 years ago

In PR #50 the maven-bundle plugin was added correctly, but somehow the <packaging>bundle</packaging> was either lost during the merge or forgotten in the first place. Without that special packaging (which is compatible to jar being the default when omitted), no OSGi manifest is generated.

Classindex 3.7 unfortunately is not usable in OSGi environments therefore.

sentinelt commented 5 years ago

@thjaeckle I think the best way to make sure it works is to write a test for it. Do you have any idea how such a test could look like?

thjaeckle commented 5 years ago

I have an idea - however this would add several test scoped dependencies like pax-exam, felix OSGi container, etc. I'm not sure if this is needed as the only thing we should look at (before a next release :)) is that the META-INF/MANIFEST.MF file created during the build must contain the line:

Export-Package: org.atteo.classindex

If you however want, I could prepare a PR for a test.